Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.x dev rx support #3735

Merged
merged 13 commits into from
Mar 26, 2019
Merged

3.x dev rx support #3735

merged 13 commits into from
Mar 26, 2019

Conversation

uglycow
Copy link
Contributor

@uglycow uglycow commented Mar 26, 2019

What is the purpose of the change

add rsocket module in bom

Brief changelog

add rsocket module in bom

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

sixie.xyn and others added 13 commits January 17, 2019 14:59
reative support
37c3414
rsocket support. support using Mono and Flux as return value.
dc37c07
reformat code, remove unused import, add license
4a502dd
optimize import
fbd6700
remove author
03d043a
@uglycow
Merge branch '3.x-dev' into 3.x-dev-rx-support
cb58c69
support using Mono/Flux as args
111ef46
Merge branch '3.x-dev-rx-support' of https://github.com/uglycow/incub…
999a5e8 
…ator-dubbo into 3.x-dev-rx-support

# Conflicts:
#	dubbo-rpc/dubbo-rpc-rsocket/src/main/java/org/apache/dubbo/rpc/protocol/rsocket/RSocketInvoker.java
#	dubbo-rpc/dubbo-rpc-rsocket/src/main/java/org/apache/dubbo/rpc/protocol/rsocket/RSocketProtocol.java
Merge remote-tracking branch 'apache_dubbo_origin/3.x-dev' into 3.x-d…
20ee08c 
…ev-rx-support

# Conflicts:
#	dubbo-rpc/dubbo-rpc-rsocket/src/main/java/org/apache/dubbo/rpc/protocol/rsocket/RSocketInvoker.java
#	dubbo-rpc/dubbo-rpc-rsocket/src/main/java/org/apache/dubbo/rpc/protocol/rsocket/RSocketProtocol.java
@chickenlj
remove unused import
f0a5624
add rsocket module
105b94f
Merge branch '3.x-dev-rx-support' of https://github.com/uglycow/incub…
9b38736 
…ator-dubbo into 3.x-dev-rx-support
Merge branch '3.x-dev' of https://github.com/apache/incubator-dubbo i…
282ad10 
…nto 3.x-dev-rx-support
@codecov-io
Copy link

Codecov Report

Merging #3735 into 3.x-dev will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             3.x-dev    #3735      +/-   ##
=============================================
+ Coverage      63.78%   63.87%   +0.09%     
  Complexity        75       75              
=============================================
  Files            656      656              
  Lines          28454    28454              
  Branches        4812     4812              
=============================================
+ Hits           18150    18176      +26     
+ Misses          8015     7996      -19     
+ Partials        2289     2282       -7
Impacted Files Coverage Δ Complexity Δ
...he/dubbo/remoting/transport/netty/NettyServer.java 67.85% <0%> (-3.58%) 0% <0%> (ø)
.../java/org/apache/dubbo/config/ReferenceConfig.java 59.64% <0%> (-0.36%) 0% <0%> (ø)
...dubbo/remoting/exchange/support/DefaultFuture.java 73.82% <0%> (+0.67%) 0% <0%> (ø) ⬇️
...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java 74.16% <0%> (+1.66%) 0% <0%> (ø) ⬇️
.../exchange/support/header/HeaderExchangeServer.java 59.82% <0%> (+1.7%) 0% <0%> (ø) ⬇️
...c/main/java/org/apache/dubbo/rpc/RpcException.java 86.2% <0%> (+3.44%) 0% <0%> (ø) ⬇️
.../apache/dubbo/remoting/transport/AbstractPeer.java 63.04% <0%> (+4.34%) 0% <0%> (ø) ⬇️
.../dubbo/remoting/transport/netty4/NettyChannel.java 65.88% <0%> (+4.7%) 0% <0%> (ø) ⬇️
...in/java/org/apache/dubbo/common/utils/JVMUtil.java 81.13% <0%> (+7.54%) 0% <0%> (ø) ⬇️
...che/dubbo/remoting/transport/mina/MinaChannel.java 53.94% <0%> (+10.52%) 0% <0%> (ø) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02cca09...282ad10. Read the comment docs.

chickenlj
chickenlj approved these changes Mar 26, 2019
View reviewed changes
Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chickenlj chickenlj merged commit d6fdd25 into apache:3.x-dev Mar 26, 2019
@dubbo-bot dubbo-bot mentioned this pull request Mar 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chickenlj chickenlj chickenlj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@uglycow @codecov-io @chickenlj